Python: Improve SARIF severity level reporting of extractor diagnostics#6928
Merged
tausbn merged 5 commits intogithub:mainfrom Oct 21, 2021
Merged
Python: Improve SARIF severity level reporting of extractor diagnostics#6928tausbn merged 5 commits intogithub:mainfrom
tausbn merged 5 commits intogithub:mainfrom
Conversation
Rename going to happen in second commit, so git doesn't get too confused I don't actually recall where to lookup that warning is 1, and error is 2, but I took this from https://github.com/github/codeql/pull/6830/files#diff-460fc20823ced3b074784db804f2d4d6cfcad4f23fe5d264dc7496c782629a2eR121-R123
I reworded this slightly from what was done in C++, such that I can completely stand behind what it says.
tausbn
requested changes
Oct 20, 2021
Contributor
tausbn
left a comment
There was a problem hiding this comment.
Two minor comments, otherwise LGTM. 👍
Co-authored-by: Taus <tausbn@github.com>
tausbn
approved these changes
Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python port of #6830
/cc @henrymercer