Skip to content

bpo-45442: Add deactivate step to venv tutorial.#28981

Merged
miss-islington merged 2 commits intopython:mainfrom
ShivnarenSrinivasan:venv
Oct 15, 2021
Merged

bpo-45442: Add deactivate step to venv tutorial.#28981
miss-islington merged 2 commits intopython:mainfrom
ShivnarenSrinivasan:venv

Conversation

@ShivnarenSrinivasan
Copy link
Contributor

@ShivnarenSrinivasan ShivnarenSrinivasan commented Oct 15, 2021 •
edited by miss-islington
Loading

@vsajip Sorry for the trouble—made a [fairly significant] git error in the previous PR.

Have edited the patch as you had said in #28959.

https://bugs.python.org/issue45442

Automerge-Triggered-By: GH:vsajip

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 15, 2021
vsajip
vsajip requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a build error which needs resolving. Did you build it locally and get a warning?

@bedevere-bot
Copy link

bedevere-bot commented Oct 15, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ShivnarenSrinivasan
Copy link
Contributor Author

ShivnarenSrinivasan commented Oct 15, 2021

@vsajip Right
Didn't know how to, so I had not built it—sorry.

Built it, and got the warning—there was a trailing line missing; fixed.

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Oct 15, 2021

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vsajip October 15, 2021 16:55
@vsajip
Copy link
Member

vsajip commented Oct 15, 2021

Didn't know how to, so I had not built it—sorry.

As you can see, even a seemingly trivial change can lead to problems. Always build and test locally before submitting a PR.

@miss-islington miss-islington merged commit 11b2ae7 into python:main Oct 15, 2021
@ShivnarenSrinivasan
Copy link
Contributor Author

ShivnarenSrinivasan commented Oct 16, 2021

Didn't know how to, so I had not built it—sorry.

As you can see, even a seemingly trivial change can lead to problems. Always build and test locally before submitting a PR.

Understood
I'll be sure to do that going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShivnarenSrinivasan @bedevere-bot @vsajip @the-knights-who-say-ni @miss-islington