Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pylint for python/taichi folder #3107

Open
ailzhang opened this issue Oct 8, 2021 · 2 comments
Open

Enable pylint for python/taichi folder #3107

ailzhang opened this issue Oct 8, 2021 · 2 comments
Labels
enhancement good first issue welcome contribution

Comments

@ailzhang
Copy link
Collaborator

@ailzhang ailzhang commented Oct 8, 2021

Currently if you run pylint python/taichi/ there're a lot of warnings/errors. We'd like to get rid of these and run pylint in CI.
Also in .pylintrc we skip a few checkers but it'd be nice to enable some of them back, e.g. import-outside-toplevel.

This work is good for new contributors, and you're welcome to submit one PR per pylint checker/rule.
@deepakdinesh1123
Copy link

@deepakdinesh1123 deepakdinesh1123 commented Oct 9, 2021

How to handle unused imports and unused variables?

@ailzhang
Copy link
Collaborator Author

@ailzhang ailzhang commented Oct 9, 2021

@deepakdinesh1123 We'll be happy to get rid of them! For example, you can run
pylint python/taichi --disable=all --enable=W0611 to get all the occurrences of unused imports. (W0612 for unused variables)

@deepakdinesh1123 deepakdinesh1123 mentioned this issue Oct 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue welcome contribution
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ailzhang @deepakdinesh1123