bpo-42960: resources module, adding RLIMIT_KQUEUES constant from FreeBSD #24251
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
Doc/library/resource.rst
Outdated
| @@ -255,6 +255,14 @@ platform. | |||
|
|
|||
| .. versionadded:: 3.4 | |||
|
|
|||
| .. data:: RLIMIT_KQUEUES | |||
|
|
|||
| The maximum number of kqueues created by this user id. | |||
There was a problem hiding this comment.
I prefer the definition from the FreeBSD manual page:
"The maximum number of kqueues this user id is allowed to create."
=> "is allowed to create" rather than "created".
| @@ -0,0 +1 @@ | |||
| Adds RLIMIT_KQUEUES constant from FreeBSD to the resources module | |||
There was a problem hiding this comment.
| Adds RLIMIT_KQUEUES constant from FreeBSD to the resources module | |
| Adds :data:`resource.RLIMIT_KQUEUES` constant from FreeBSD to the :mod:`resource` module. |
Doc/library/resource.rst
Outdated
| @@ -255,6 +255,14 @@ platform. | |||
|
|
|||
| .. versionadded:: 3.4 | |||
|
|
|||
| .. data:: RLIMIT_KQUEUES | |||
|
|
|||
| The maximum number of kqueues is allowed to create by this user id. | |||
There was a problem hiding this comment.
it's still different than the sentence from the FreeBSD manual page, this sentence sounds wrong to me.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
| @@ -0,0 +1 @@ | |||
| Adds :data:`resources.RLIMIT_KQUEUES` constant from FreeBSD to the :mod:`resources` module | |||
There was a problem hiding this comment.
please put a trailing dot to your sentence (and fix the typo in the module name)
https://bugs.python.org/issue42960