Skip to content

/ appsmith Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] : Page properties icon next to page name looks like an attanchment #8013

Open
prapullac opened this issue Sep 30, 2021 · 16 comments
Open

[Enhancement] : Page properties icon next to page name looks like an attanchment #8013

prapullac opened this issue Sep 30, 2021 · 16 comments
Labels
Good First Issue hacktoberfest Low Needs Triaging Pages Release UI Builders Pod UI Building Pod UX Improvement

Comments

@prapullac
Copy link
Contributor

@prapullac prapullac commented Sep 30, 2021

Steps to reproduce:

  1. Create multiple new pages
  2. Click on the setting option in the entity explorer
  3. List of pages are displayed to the user
  4. focus on any of the pages
    observe the icon next to page name

Observation:
The icon looks more like an attachment icon rather than an icon to launch the page

Expectation:
It is expected that the icon can be more related to the launch of page.
Screenshot 2021-09-30 at 5 28 20 PM
@Nikhil-Nandagopal Nikhil-Nandagopal removed their assignment Sep 30, 2021
@ArmanChand
Copy link

@ArmanChand ArmanChand commented Oct 1, 2021 •
edited

Hello @somangshu ,
I can take this Issue. Please assign it to me

@somangshu
Copy link
Contributor

@somangshu somangshu commented Oct 1, 2021

@prapullac I disagree to this, this is the most common representation of a link, Check out this screenshot of quick google search link icon
Screenshot 2021-10-01 at 2 24 22 PM

Attachment icon is usually a paperclip. Closing this for now.

@ArmanChand This issue dosent seem valid to me right now, Ill have a discussion around this get back. Meanwhile to find more issue search for the label good first issue or hacktoberfest to find something relevant to work on. Do tag me, ill assign it to you. Happy hacking

@somangshu somangshu closed this Oct 1, 2021
@somangshu
Copy link
Contributor

@somangshu somangshu commented Oct 1, 2021

If it makes sense we could probably switch to something like
Screenshot 2021-10-01 at 2 28 55 PM

Please re-open if required

@prapullac
Copy link
Contributor Author

@prapullac prapullac commented Oct 1, 2021

@somangshu the above icon looks more relevant and we can make changes accordingly.

@prapullac prapullac reopened this Oct 1, 2021
@somangshu
Copy link
Contributor

@somangshu somangshu commented Oct 1, 2021

In that case, @ArmanChand, This is all your 🎉 . Assigning this to you now.

Please don't forget to read the Contribution Guidelines. Would appreciate if you can open a PR within the next 2 days.

Also, please don't forget to register with Appsmith's Hacktoberfest Community in order to be eligible for Appsmith swag.

@Nikhil-Nandagopal
Copy link
Contributor

@Nikhil-Nandagopal Nikhil-Nandagopal commented Oct 1, 2021

The above icon is wrong. It's used to depict that it will open in a new tab.
@momcilo-appsmith could you please help here?

@ArmanChand please don't raise a PR for this just yet :)

@ArmanChand
Copy link

@ArmanChand ArmanChand commented Oct 1, 2021

hello @Nikhil-Nandagopal ,
Waiting for the icon confirmation, once done please inform me, i will start working on it.

@amanjhurani
Copy link

@amanjhurani amanjhurani commented Oct 1, 2021 •
edited

Hello @somangshu @Nikhil-Nandagopal
It's a kind of webpage a user will be building by clicking on icon. Which will open page in editing mode. I found some icons which matching with the context.

2

I would to love to contribute. Please assign it to me, If you liked these icons.

@ashish921998
Copy link

@ashish921998 ashish921998 commented Oct 2, 2021

@Nikhil-Nandagopal I would love to work on this issue.

@pawankm21
Copy link

@pawankm21 pawankm21 commented Oct 2, 2021

I have some suggestions.


The first one looks more relevant to me
image

@somangshu
Copy link
Contributor

@somangshu somangshu commented Oct 3, 2021

@momcilo-appsmith Found out that this is actually representing edit page.

cc @areyabhishek @jsartisan

@bhavy2908
Copy link

@bhavy2908 bhavy2908 commented Oct 3, 2021

I would like to work on this

@Aarushi5g
Copy link

@Aarushi5g Aarushi5g commented Oct 3, 2021

Hello, the most relevant icon for preview seems to be this one!

image

Please let me know what you think and I'll be more than happy to work and complete the issue further!!
Thank you :)

@ps-19
Copy link

@ps-19 ps-19 commented Oct 3, 2021 •
edited

what about this one:

icon

i would work on this issue kindly assign me.

@ion05
Copy link

@ion05 ion05 commented Oct 4, 2021

@prapullac can i work on this ?

@SrinidhiKulkarni28
Copy link

@SrinidhiKulkarni28 SrinidhiKulkarni28 commented Oct 4, 2021 •
edited

Is this still open? If yes can I work on this?
@prapullac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue hacktoberfest Low Needs Triaging Pages Release UI Builders Pod UI Building Pod UX Improvement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet