Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Add a missing apostrophe in a code example in venv.rst #28391

Merged
merged 2 commits into from Sep 17, 2021
Merged

[doc] Add a missing apostrophe in a code example in venv.rst #28391

merged 2 commits into from Sep 17, 2021
+1 −1

Conversation

@ArkaprabhaChakraborty
Copy link
Contributor

@ArkaprabhaChakraborty ArkaprabhaChakraborty commented Sep 16, 2021

documentation update
@ArkaprabhaChakraborty
added missing ' in main
92f4b6d 
documentation update
ambv
ambv reviewed Sep 17, 2021
View changes
Doc/library/venv.rst Outdated
help='A directory in which to create the'
'virtual environment.')
Copy link
Contributor

@ambv ambv Sep 17, 2021

You need a space before the apostrophe.

Copy link
Contributor Author

@ArkaprabhaChakraborty ArkaprabhaChakraborty Sep 17, 2021

Oh yes. But the sample code was giving an error so I just sent a change to resolve it. Ill add the space

@ArkaprabhaChakraborty
space added
e5153b2
@ArkaprabhaChakraborty ArkaprabhaChakraborty requested a review from ambv Sep 17, 2021
@ambv ambv changed the title added missing ' in main [doc] Add a missing apostrophe in a code example in venv.rst Sep 17, 2021
@ambv ambv merged commit d22a700 into python:main Sep 17, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 17, 2021

Thanks @ArkaprabhaChakraborty for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 17, 2021

GH-28425 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 17, 2021

GH-28426 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Sep 17, 2021
@ArkaprabhaChakraborty @miss-islington
[doc] Add a missing apostrophe in a code example in venv.rst (pythonG…
e0fd060 
…H-28391)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
miss-islington added a commit to miss-islington/cpython that referenced this issue Sep 17, 2021
@ArkaprabhaChakraborty @miss-islington
[doc] Add a missing apostrophe in a code example in venv.rst (pythonG…
64a253e 
…H-28391)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
ambv pushed a commit that referenced this issue Sep 17, 2021
@ArkaprabhaChakraborty @miss-islington
[doc] Add a missing apostrophe in a code example in venv.rst (GH-28391)…
c4be7ca 
… (GH-28425)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
ambv pushed a commit that referenced this issue Sep 17, 2021
@ArkaprabhaChakraborty @miss-islington
[doc] Add a missing apostrophe in a code example in venv.rst (GH-28391)…
129e477 
… (GH-28426)

(cherry picked from commit d22a700)

Co-authored-by: Arkaprabha Chakraborty <chakrabortyarkaprabha998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip

@ambv ambv

Assignees
No one assigned
Labels
CLA signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@ArkaprabhaChakraborty @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni