Skip to content

docs: correct references to __isub__ etc#28297

Merged
serhiy-storchaka merged 1 commit intopython:mainfrom
davidhewitt:patch-1
Sep 16, 2021
Merged

docs: correct references to __isub__ etc#28297
serhiy-storchaka merged 1 commit intopython:mainfrom
davidhewitt:patch-1

Conversation

@davidhewitt
Copy link
Contributor

Looking at the sub-slots table in https://docs.python.org/3.9/c-api/typeobj.html#sub-slots, it looked to be that the inplace methods such as __isub__ were incorrectly referring to the non-inplace methods such as __sub__? This PR corrects those typos, if I am correct.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@davidhewitt

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@miss-islington
Copy link
Contributor

Thanks @davidhewitt for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @davidhewitt and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 800bd01b6d365156403c3dde61765dc5fdbf64be 3.9

@bedevere-bot
Copy link

GH-28383 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2021
(cherry picked from commit 800bd01)

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Sep 16, 2021
(cherry picked from commit 800bd01)

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Sep 17, 2021
(cherry picked from commit 800bd01)

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@bedevere-bot
Copy link

GH-28415 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka added a commit that referenced this pull request Sep 17, 2021
(cherry picked from commit 800bd01)

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Sep 29, 2021
(cherry picked from commit 800bd01)

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants