JS/Java: use the correct cwe tags#6694
Merged
erik-krogh merged 1 commit intogithub:mainfrom Sep 15, 2021
Merged
Conversation
bmuskalla
approved these changes
Sep 14, 2021
Contributor
bmuskalla
left a comment
There was a problem hiding this comment.
Just checked that our docs recommend the same tags as well: Security queries should also be tagged with corresponding CWE numbers, for example external/cwe/cwe-119 (prefer the most specific CWE that encompasses the target of the query).
Contributor
|
@erik-krogh do you think it makes sense to make this part of some validation? |
Contributor
Author
I don't think so. |
Contributor
|
@Moose0621 Not sure if the run experimental queries against the OWASP benchmark but this may improve those results a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vast majority of queries use
external/cwe/cwe-XXtags for documenting their CWE coverage.But a few used
external/cwe-XX.For consistency I've changed all the
external/cwe-XXtags to theexternal/cwe/cwe-XXform.This also fixes some scripting that detects CWE coverage.