Skip to content

Fix incompatibility with release CLI#6565

Merged
aeisenberg merged 1 commit intomainfrom
dbartol/suite-helpers-incomatbility
Aug 27, 2021
Merged

Fix incompatibility with release CLI#6565
aeisenberg merged 1 commit intomainfrom
dbartol/suite-helpers-incomatbility

Conversation

@dbartol
Copy link
Copy Markdown

@dbartol dbartol commented Aug 27, 2021

This fixes #6563, in which a customer reports being unable to run a query suite despite following the "Getting Started with the CodeQL CLI" instructions. The problem is that the released versions of the CodeQL CLI incorrectly disallow any reference to a library pack from within a .qls file. This is a CLI bug that will be fixed in the next CLI release, but since our policy is to make github/codeql's main branch compatible with the latest released CLI, we need to work around this for now by pretending codeql/suite-helpers is a query pack.

This fixes #6563, in which a customer reports being unable to run a query suite despite following the "Getting Started with the CodeQL CLI" instructions. The problem is that the released versions of the CodeQL CLI incorrectly disallow any reference to a library pack from within a .qls file. This is a CLI bug that will be fixed in the next CLI release, but since our policy is to make `github/codeql`'s `main` branch compatible with the latest released CLI, we need to work around this for now by pretending `codeql/suite-helpers` is a query pack.
@dbartol dbartol requested a review from aeisenberg August 27, 2021 18:18
@dbartol dbartol added bug Something isn't working no-change-note-required This PR does not need a change note labels Aug 27, 2021
@dbartol
Copy link
Copy Markdown
Author

dbartol commented Aug 27, 2021

Please do not merge until #6566 shows green. That PR tweaks a few additional files to force all of the language tests to run.

@aeisenberg aeisenberg merged commit bf15b18 into main Aug 27, 2021
@aeisenberg aeisenberg deleted the dbartol/suite-helpers-incomatbility branch August 27, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem running LGTM python query suite

2 participants