Implicit downcast involving references #6537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in testcase, and add 'GOOD' annotation to the testcase
|
I'm unsure if a change note is required for this PR. |
rdmarsh2
reviewed
Aug 23, 2021
cpp/ql/src/Likely Bugs/Conversion/ImplicitDowncastFromBitfield.ql
Outdated
Show resolved
Hide resolved
|
LGTM, modulo @rdmarsh2's comment. Including a change note is the right thing to do. It goes in https://github.com/github/codeql/tree/main/cpp/change-notes, and you can see the style and conventions by looking at a few other recent change notes. |
|
I've added a change-note. I'm somewhat unsure on what to write in it, so please do not hesitate to comment so I can learn. |
geoffw0
reviewed
Aug 24, 2021
Co-authored-by: Jonas Jensen <jbj@github.com>
jbj
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for implict downcast when using references, and fix the test to detect implicit downcasts when using references, which was not previously not detected.