Show dependencies feature #1012 #1165

fzanollo · 2021-06-14T17:35:43Z

Contains:

implementation of show dependencies feature for commands: install, show, upgrade, uninstall, validate, import.
everything under a new experimental feature
unit testcases for each of the commands
Closes #1012

Microsoft Reviewers: Open in CodeFlow

… import

doc/Settings.md

src/AppInstallerCLICore/Commands/UninstallCommand.cpp

src/AppInstallerCLICore/Commands/UpgradeCommand.cpp

src/AppInstallerCLICore/Commands/ValidateCommand.cpp

src/AppInstallerCLICore/Workflows/UpdateFlow.cpp

src/AppInstallerCLITests/AppInstallerCLITests.vcxproj

src/AppInstallerCLITests/AppInstallerCLITests.vcxproj.filters

src/AppInstallerCLITests/WorkFlow.cpp

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h

…nciesFlow

jjvrmorales367

approve

…dencyList; add Dependency to context data

github-actions · 2021-06-18T18:47:00Z

Misspellings found, please review:

deps

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"bcp cdn compschema Debian google INET Langs oss REINSTALLMODE smartscreen sourc Standalone vamus Wunused "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"debian deps inet langs "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

…DpeendencyType

…es task divided, creates ValidateFlow

…DependencyList.dependencies private, code style

src/AppInstallerCLICore/Workflows/InstallFlow.cpp

src/AppInstallerCLICore/Workflows/UninstallFlow.cpp

src/AppInstallerCLICore/Workflows/ValidateFlow.cpp

src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>

…encies is now a WorkflowTask receiving resource string id

…w, move dependency related function to DependenciesFlow

github-actions · 2021-06-23T18:18:29Z

Misspellings found, please review:

begining

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"bcp cdn compschema Debian google INET Langs oss REINSTALLMODE smartscreen sourc Standalone vamus Wunused "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"begining debian inet langs "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

github-actions · 2021-06-23T19:18:28Z

Misspellings found, please review:

begining

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"bcp cdn compschema Debian google INET Langs oss REINSTALLMODE smartscreen sourc Standalone vamus Wunused "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"begining debian inet langs "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

…ion if needed

…installer are preferred

github-actions · 2021-06-24T17:13:27Z

Misspellings found, please review:

IISOn
Multideclaration

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"bcp cdn compschema Debian google INET Langs oss REINSTALLMODE smartscreen sourc Standalone vamus Wunused "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"debian IISOn inet langs Multideclaration "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h

github-actions · 2021-06-24T19:19:12Z

Misspellings found, please review:

standalone

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"abifind CLSID combaseapi cppwinrtprocess Globals HRESULTs IApp idl IFind IGet iinstall MIDL Packageend pseudocode Xaml "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"clsid globals hresults midl standalone "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

github-actions · 2021-06-24T19:52:38Z

Misspellings found, please review:

standalone

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"abifind CLSID combaseapi cppwinrtprocess Globals HRESULTs IApp idl IFind IGet iinstall MIDL Packageend pseudocode Xaml "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"clsid globals hresults midl standalone "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

github-actions · 2021-06-24T21:06:18Z

Misspellings found, please review:

standalone

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"abifind CLSID combaseapi cppwinrtprocess Globals HRESULTs IApp idl IFind IGet iinstall MIDL Packageend pseudocode Xaml "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"clsid globals hresults midl standalone "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h

fzanollo added 14 commits Jun 4, 2021

first tests for show depenencies feature

9c72b02

show dependencies feature for show, install, need to change message

0a81ec5

showflow output changed

b416985

install commands shows dependencies as in specs

c848824

tests for informing dependencies on commands: show, install, upgrade,…

688cbe5

… import

refactor install flow

7b488f1

change import command from install flow (install multiple)

c8d02ea

import shows all dependencies together

72fd209

show dependencies for validate and uninstall

d6d0c53

tests for validate and uninstall

d3063f2

create show dependencies exp feature

9d05f6f

test for validate command

e3ccc8e

put functionality under experimental feature check

44fe9e2

enable show dep experimental feature on unit test cases

a69b930

fzanollo requested a review from JohnMcPMS Jun 14, 2021

fzanollo requested a review from microsoft/windows-package-manager-admins as a code owner Jun 14, 2021

msftbot bot added the Issue-Feature label Jun 14, 2021

JohnMcPMS requested changes Jun 15, 2021

View changes

msftbot bot added the Needs-Author-Feedback label Jun 15, 2021

change experimental feature name

8bb3aa1

msftbot bot removed the Needs-Author-Feedback label Jun 15, 2021

fzanollo added 3 commits Jun 15, 2021

remove info stream characters on testcase

9737ae1

move check for exp feature inside report function, create new Depende…

49c7fea

…nciesFlow

DependenciesFlow header and cpp inside Workflow

74d29ff

jjvrmorales367 approved these changes Jun 15, 2021

View changes

fzanollo added 2 commits Jun 18, 2021

�change representation of Dependency, create DependencyType and Depen…

b7590c3

…dencyList; add Dependency to context data

dependencies context data is of type DependencyList (not optional)

b04225a

fzanollo added 2 commits Jun 18, 2021

fix spelling errors

2a620d8

ApplyTo function, can receibe a lambda function to apply on specific …

40e05b4

…DpeendencyType

msftbot bot added Needs-Author-Feedback and removed Needs-Author-Feedback labels Jun 21, 2021

fzanollo added 3 commits Jun 22, 2021

localize user strings, code style changes, validate report dependenci…

d8c411f

…es task divided, creates ValidateFlow

change uninstall flow (gets dependencies from package version), make …

9f3961a

…DependencyList.dependencies private, code style

add missing report dep on upgrade

1c6347f

JohnMcPMS requested changes Jun 22, 2021

View changes

msftbot bot added Needs-Author-Feedback and removed Needs-Author-Feedback labels Jun 22, 2021

fzanollo and others added 4 commits Jun 23, 2021

Update src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

c785b14

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>

compare id with ICU case insensitive

0a31f79

move dependencies related functions to DependenciesFlow, ReportDepend…

af7b09c

…encies is now a WorkflowTask receiving resource string id

TODO to get dependencies on uninstall context, remove testcase for no…

8fce81d

…w, move dependency related function to DependenciesFlow

wfIds not temporary

af036e4

fzanollo added 2 commits Jun 23, 2021

DependencyList Add function checks for existence and updates min vers…

3388ea7

…ion if needed

root dependencies are used when installer are not present, otherwise …

f07fdc6

…installer are preferred

fzanollo added 2 commits Jun 24, 2021

add tests names to spelling expect

5eb6270

merge commits from master

c8e9e27

JohnMcPMS reviewed Jun 24, 2021

View changes

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h Outdated Show resolved Hide resolved

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h Show resolved Hide resolved

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h Outdated Show resolved Hide resolved

style and details

0bbe093

fix merge conflicts

f0f3676

spellcheck exception

dd03b85

fzanollo requested a review from JohnMcPMS Jun 25, 2021

JohnMcPMS reviewed Jun 25, 2021

View changes

src/AppInstallerCommonCore/Public/winget/ManifestCommon.h Outdated Show resolved Hide resolved

detail when adding dep

2985cd5

microsoft / winget-cli

Show dependencies feature #1012 #1165

Show dependencies feature #1012 #1165

fzanollo commented Jun 14, 2021 •

edited by msftbot bot

jjvrmorales367 left a comment

github-actions bot commented Jun 18, 2021

github-actions bot commented Jun 23, 2021

github-actions bot commented Jun 23, 2021

github-actions bot commented Jun 24, 2021

github-actions bot commented Jun 24, 2021

github-actions bot commented Jun 24, 2021

github-actions bot commented Jun 24, 2021

microsoft / winget-cli

Show dependencies feature #1012 #1165

Are you sure you want to change the base?

Show dependencies feature #1012 #1165

Conversation

fzanollo commented Jun 14, 2021 • edited by msftbot bot

Microsoft Reviewers: Open in CodeFlow

jjvrmorales367 left a comment

github-actions bot commented Jun 18, 2021

Misspellings found, please review:

github-actions bot commented Jun 23, 2021

Misspellings found, please review:

github-actions bot commented Jun 23, 2021

Misspellings found, please review:

github-actions bot commented Jun 24, 2021

Misspellings found, please review:

github-actions bot commented Jun 24, 2021

Misspellings found, please review:

github-actions bot commented Jun 24, 2021

Misspellings found, please review:

github-actions bot commented Jun 24, 2021

Misspellings found, please review:

fzanollo commented Jun 14, 2021 •

edited by msftbot bot