Skip to content

C++: Allow querying for "C" language linkage on routine types.#6496

Merged
sashabu merged 1 commit intogithub:mainfrom
sashabu:sashabu/c_linkage
Aug 18, 2021
Merged

C++: Allow querying for "C" language linkage on routine types.#6496
sashabu merged 1 commit intogithub:mainfrom
sashabu:sashabu/c_linkage

Conversation

@sashabu
Copy link
Copy Markdown
Contributor

@sashabu sashabu commented Aug 17, 2021

No description provided.

@sashabu sashabu added enhancement New feature or request C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR labels Aug 17, 2021
@sashabu sashabu force-pushed the sashabu/c_linkage branch from f38a747 to b1acfee Compare August 18, 2021 13:34
@sashabu sashabu requested a review from AlexDenisov August 18, 2021 13:37
@sashabu sashabu marked this pull request as ready for review August 18, 2021 13:37
@sashabu sashabu requested a review from a team as a code owner August 18, 2021 13:37
Copy link
Copy Markdown
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sashabu sashabu force-pushed the sashabu/c_linkage branch from b1acfee to e774873 Compare August 18, 2021 13:51
@sashabu sashabu requested a review from geoffw0 August 18, 2021 13:53
geoffw0
geoffw0 previously approved these changes Aug 18, 2021
Copy link
Copy Markdown
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

Copy link
Copy Markdown
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are passing in the corresponding code commit. 👍

@sashabu sashabu merged commit 1eb804a into github:main Aug 18, 2021
@sashabu sashabu deleted the sashabu/c_linkage branch August 18, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants