Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Add @kind to deferinloop.ql#552

Merged
smowton merged 1 commit into
mainfrom
deferinloop-kind
Jul 19, 2021
Merged

Add @kind to deferinloop.ql#552
smowton merged 1 commit into
mainfrom
deferinloop-kind

Conversation

@sampart

@sampart sampart commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Required to use this query with the CodeQL CLI

Required to use this query with the CodeQL CLI
@sampart sampart requested a review from alexrford July 16, 2021 13:26
@sampart sampart requested a review from a team as a code owner July 16, 2021 13:26
@owen-mc

owen-mc commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

This is in the snippets folder, which are to give users a starting point, showing them how to do some basic things. None of the other snippets seem to have this. So if we want to add it, we should add it to all of them.

@sampart

sampart commented Jul 16, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @owen-mc. I'm planning on referencing this query in a blog post, and want to make sure that users can add it to their workflows directly. Given that people might be using it in that way in future, should it be moved somewhere else?

@sampart

sampart commented Jul 16, 2021

Copy link
Copy Markdown
Contributor Author

Alternatively, I'm happy to add @kind to the other queries here. Up to you.

@smowton smowton enabled auto-merge July 19, 2021 10:17
@smowton smowton disabled auto-merge July 19, 2021 10:17
@smowton smowton closed this Jul 19, 2021
@smowton smowton reopened this Jul 19, 2021
@smowton smowton merged commit e39753c into main Jul 19, 2021
@owen-mc owen-mc deleted the deferinloop-kind branch July 19, 2021 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants