Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure LICENSE file is regenerated even in PGO builds #27580

Merged
merged 1 commit into from Aug 3, 2021
Merged

Conversation

@zooba
Copy link
Member

@zooba zooba commented Aug 3, 2021

No description provided.

@zooba
Copy link
Member Author

@zooba zooba commented Aug 3, 2021

@pablogsal FYI, but I think I've got a fix for the current release, so we won't need to restart it.

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 3, 2021

@pablogsal FYI, but I think I've got a fix for the current release, so we won't need to restart it.

Nice! If you find the fix for the current release too complex, I can restart the release after work.

@zooba
Copy link
Member Author

@zooba zooba commented Aug 3, 2021

The quick fix was to run the build twice to make sure the file is there, so it just added a few minutes. Looks like it's past the point where it failed the first time though, so the only reason we might rebuild is if it's too obvious that the build scripts came from my fork instead of the main repo (but I don't think that'll be obvious).

@zooba zooba merged commit 6871fd0 into python:main Aug 3, 2021
12 checks passed
12 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210803.16 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue report skipped
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 3, 2021

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 3, 2021

Sorry @zooba, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6871fd0e8e5257f3ffebd1a1b2ca50e5f494e7f6 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 3, 2021

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 3, 2021

Sorry, @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6871fd0e8e5257f3ffebd1a1b2ca50e5f494e7f6 3.10

@zooba zooba deleted the zooba:regen-fix branch Aug 3, 2021
zooba added a commit to zooba/cpython that referenced this pull request Aug 3, 2021
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 3, 2021

GH-27582 is a backport of this pull request to the 3.10 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants