Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33479: Remove unqualified tkinter threadsafe claim. #6990

Merged
merged 2 commits into from Aug 10, 2021
Merged

bpo-33479: Remove unqualified tkinter threadsafe claim. #6990

merged 2 commits into from Aug 10, 2021

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented May 19, 2018 •
edited by bedevere-bot

It has not been true for several years and likely never was.
An explanation of what is true may be added later, after discussion,
and possibly after patching, but not before the coming 3.7.0rc1 release.

https://bugs.python.org/issue33479

taleinat
taleinat approved these changes Sep 25, 2018
View changes
Copy link
Contributor

@taleinat taleinat left a comment

I agree that we should make this change now, and further consider additional clarification as per the discussion on the issue.

@terryjreedy
Copy link
Member Author

terryjreedy commented Oct 27, 2018

Serhiy, unless you object, I plan to merge this in a day or two after the tests pass.
The outputs for VSTS: Linux and Windows just say "X Build not found"

@terryjreedy terryjreedy reopened this Oct 27, 2018
@terryjreedy terryjreedy requested a review from zooba Oct 27, 2018
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 27, 2018

The true is that _tkinter provides a threadsafe mechanism which allows Python and Tcl to interact. Its code could be simpler without it. If it doesn't always work, this can be classified as a bug and should be fixed. The fact that Python contains bugs should not mean that we should remove any claims about intended behavior.

@terryjreedy terryjreedy removed the request for review from zooba Oct 27, 2018
@terryjreedy
Copy link
Member Author

terryjreedy commented Oct 27, 2018

Requesting a review from Steve Dower was an accident. I was going to ask him about removing the failing VSTS tests but then discovered that they no longer matter.

@terryjreedy
Copy link
Member Author

terryjreedy commented Oct 27, 2018 •
edited by bedevere-bot

The tkinter thread code for threaded tcl works. The code for non-threaded tcl does not. See bpo-33257. I strongly feel that we should stop deceiving users with the latter into wasting time making futile attempts destined to fail. As my initial comment implies, this stripped down PR was only intended to be a minimal stop-gap, pending agreement on a replacement.

My initial post on the bpo issue proposes a proposed replacement sentence and a new section for the tkinter doc that say the minimum that I think users should know, including how to identify which tcl build they have. I would prefer to include the full proposal in this PR. If you approve of it, or are at least willing to discuss it, I will add it.

@vstinner
Copy link
Member

vstinner commented Jan 10, 2019

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@matrixise
Copy link
Member

matrixise commented Sep 11, 2019

@terryjreedy Could I merge this one? Thank you

terryjreedy added 2 commits Aug 10, 2021
@terryjreedy @ambv
bpo-33479: Remove unqualified tkinter threadsafe claim.
94fb77b 
It has not been true for several years and likely never was.
An explanation of what is true may be added later, after discussion,
and possible after patching, but not before the coming 3.7.0rc1 release.
@terryjreedy @ambv
add blurb
7913f6b
@ambv ambv merged commit 6b37d0d into python:main Aug 10, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 10, 2021

Thanks @terryjreedy for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2021
@terryjreedy @miss-islington
bpo-33479: Remove unqualified tkinter threadsafe claim. (pythonGH-6990)
1e640d2 
It has not been true for several years and likely never was.
(cherry picked from commit 6b37d0d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

bedevere-bot commented Aug 10, 2021

GH-27704 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2021
@terryjreedy @miss-islington
bpo-33479: Remove unqualified tkinter threadsafe claim. (pythonGH-6990)
04f9139 
It has not been true for several years and likely never was.
(cherry picked from commit 6b37d0d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

bedevere-bot commented Aug 10, 2021

GH-27705 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Aug 10, 2021
@miss-islington @terryjreedy
bpo-33479: Remove unqualified tkinter threadsafe claim. (GH-6990)
2e1fef5 
It has not been true for several years and likely never was.
(cherry picked from commit 6b37d0d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
ambv pushed a commit that referenced this pull request Aug 10, 2021
@miss-islington @terryjreedy
bpo-33479: Remove unqualified tkinter threadsafe claim. (GH-6990) (GH…
c7dfbd2 
…-27705)

It has not been true for several years and likely never was.
(cherry picked from commit 6b37d0d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@native-api native-api mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@terryjreedy @serhiy-storchaka @vstinner @matrixise @miss-islington @bedevere-bot @taleinat @ambv @ned-deily @the-knights-who-say-ni