Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44838: Refine the custom syntax errors for invalid 'if' expressions #27615

Merged
merged 1 commit into from Aug 5, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 5, 2021

Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Nice idea!

@pablogsal
Copy link
Member Author

pablogsal commented Aug 5, 2021

Thanks for the review!

@pablogsal pablogsal merged commit f5cbea6 into python:main Aug 5, 2021
13 checks passed
@pablogsal pablogsal deleted the bpo-44838 branch Aug 5, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Aug 5, 2021

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Aug 5, 2021

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f5cbea6b1b5fc39cca377c6cc93f222916015fc4 3.10

pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 5, 2021
…pressions (pythonGH-27615).

(cherry picked from commit f5cbea6)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 5, 2021

GH-27616 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit that referenced this pull request Aug 5, 2021
…pressions (GH-27615). (GH-27616)

…

(cherry picked from commit f5cbea6)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Automerge-Triggered-By: GH:lysnikolaou
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants