➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2020-06-25 16:35 by WildCard65, last changed 2021-08-04 16:09 by vstinner. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| cpython.patch | WildCard65, 2020-06-25 16:35 | Proposed patch for the GC module. | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 27593 | merged | vstinner, 2021-08-04 15:35 | |
| Messages (4) | |||
|---|---|---|---|
| msg372380 - (view) | Author: William Pickard (WildCard65) * | Date: 2020-06-25 16:35 | |
When the GC module goes to collect objects (most notably, during Python shutdown), it makes a call to subtract_refs on the GC container. During this invocation, it creates a local variable "op" who's value is the result of 'FROM_GC(gc)', but when it goes to use the obtained 'traverse' method, it calls FROM_GC(gc) instead of using 'op'. This, unfortunately, makes it rather difficult to debug "Access Violations" for extension modules for when 'traverse' is 'NULL' as inspecting the variable 'op' in the chosen debugger (for my case: Visual Studio on Windows) is impossible. This can potentially introduce a micro optimization in the overall runtime of the GC module as it no longer has to invoke the addition instruction (if it does) to construct the first parameter of the 'traverse' call. |
|||
| msg398906 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2021-08-04 15:36 | |
I created PR 27593. |
|||
| msg398909 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2021-08-04 16:09 | |
New changeset c34fa2bb06ea44045af8493dfa414addb2b7ce66 by Victor Stinner in branch 'main': bpo-41117: Cleanup subtract_refs() (GH-27593) https://github.com/python/cpython/commit/c34fa2bb06ea44045af8493dfa414addb2b7ce66 |
|||
| msg398910 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2021-08-04 16:09 | |
Thanks William, I made the change that you suggested. Next time, please create a PR directly ;-) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2021-08-04 16:09:51 | vstinner | set | status: open -> closed versions: + Python 3.11, - Python 3.10 messages: + msg398910 resolution: fixed stage: patch review -> resolved |
| 2021-08-04 16:09:31 | vstinner | set | messages: + msg398909 |
| 2021-08-04 15:36:03 | vstinner | set | messages: + msg398906 |
| 2021-08-04 15:35:05 | vstinner | set | nosy:
+ vstinner pull_requests: + pull_request26094 stage: patch review |
| 2020-06-25 16:35:27 | WildCard65 | create | |