Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Goreleaser, take 2 #4043

Merged
merged 2 commits into from Jul 28, 2021
Merged

Update Goreleaser, take 2 #4043

merged 2 commits into from Jul 28, 2021

Conversation

@mislav
Copy link
Member

@mislav mislav commented Jul 26, 2021

Previously: #3926
Reverts commit 85d0447.

Verified via:

$ goreleaser release --skip-publish --skip-validate --rm-dist
$ docker run --rm -ti -v "$PWD/dist:/dist" ubuntu:focal dpkg -c /dist/gh_1.13.1_linux_amd64.deb
drwxr-xr-x 0/0               0 2021-07-26 13:01 ./usr/
drwxr-xr-x 0/0               0 2021-07-26 13:01 ./usr/bin/
-rwxr-xr-x 0/0        28893184 2021-07-26 13:01 ./usr/bin/gh
@mislav
Update Goreleaser
69262d1 
This reverts commit 85d0447.
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jul 26, 2021
samcoe
samcoe approved these changes Jul 26, 2021
View changes
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jul 26, 2021
@mislav mislav merged commit 5a46c1c into trunk Jul 28, 2021
10 checks passed
Loading
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jul 28, 2021
@mislav mislav deleted the upgrade-goreleaser branch Jul 28, 2021
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe

Assignees
No one assigned
Labels
None yet
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@mislav @samcoe