Skip to content

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Jun 21, 2021

  • Extensions on Windows now enabled through the sh.exe interpreter
  • sh.exe now found on Windows when git was installed via scoop
  • gh extensions list command shows origin repo for the extension
  • gh extensions upgrade --all is required to upgrade all extensions
  • Added gh extensions remove
  • Shell completions now include aliases and extension names
  • Adding an alias for an extension is now allowed
  • gh help output now lists available extension names
  • Extensions are now installed to XDG_DATA_HOME
  • Tests

Followup to #3761
Ref. https://github.com/github/cli/issues/69

mislav added 2 commits June 21, 2021 16:54
- Extensions on Windows now enabled through the `sh.exe` interpreter
- `sh.exe` now found on Windows when git was installed via scoop
- `gh extensions list` command shows origin repo for the extension
- `gh extensions upgrade --all` is required to upgrade all extensions
- Added `gh extensions remove`
- Shell completions now include aliases and extension names
- `gh` help output now lists available extension names
- Extensions are stored to XDG_DATA_HOME
@mislav mislav force-pushed the extensions-revisited branch from 5dfdd1f to f99191e Compare June 21, 2021 14:54
@vilmibm vilmibm self-requested a review June 21, 2021 22:56
This was referenced Jun 23, 2021
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no blocking feedback on the code in this PR (and didn't want to keep it from merging any longer given its size) 👍

I did produce a pile of extensions feedback, though, and opened it here: #3895

@samcoe samcoe merged commit 33c3fb5 into trunk Jun 29, 2021
@samcoe samcoe deleted the extensions-revisited branch June 29, 2021 00:12
@mislav mislav mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants