Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44720: Don't crash when calling weakref.proxy(not_an_iterator).__next__ #27316

Merged
merged 3 commits into from Jul 24, 2021
Merged

bpo-44720: Don't crash when calling weakref.proxy(not_an_iterator).__next__ #27316

merged 3 commits into from Jul 24, 2021

Conversation

@sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Jul 24, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44720
@ambv ambv merged commit 5370f0a into python:main Jul 24, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 24, 2021

Thanks @sweeneyde for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 24, 2021
@sweeneyde @miss-islington
bpo-44720: Don't crash when calling weakref.proxy(not_an_iterator).__…
f5cf90e 
…next__ (pythonGH-27316)

(cherry picked from commit 5370f0a)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 24, 2021

GH-27324 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 24, 2021

GH-27325 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 24, 2021
@sweeneyde @miss-islington
bpo-44720: Don't crash when calling weakref.proxy(not_an_iterator).__…
f6f4c03 
…next__ (pythonGH-27316)

(cherry picked from commit 5370f0a)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
ambv pushed a commit that referenced this issue Jul 24, 2021
@sweeneyde @miss-islington
bpo-44720: Don't crash when calling weakref.proxy(not_an_iterator).__…
659030c 
…next__ (GH-27316) (GH-27324)

(cherry picked from commit 5370f0a)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
ambv pushed a commit that referenced this issue Jul 24, 2021
@sweeneyde @miss-islington
bpo-44720: Don't crash when calling weakref.proxy(not_an_iterator).__…
0a08f22 
…next__ (GH-27316) (#27325)

(cherry picked from commit 5370f0a)

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@sweeneyde @JuniorJPDJ
bpo-44720: Don't crash when calling weakref.proxy(not_an_iterator).__…
c138834 
…next__ (pythonGH-27316)
@sweeneyde sweeneyde deleted the proxy_iter branch Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@sweeneyde @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni