Skip to content

Java: Fix a bug in call-context-sensitve dispatch to SummarizedCallable.#6313

Merged
aschackmull merged 1 commit intogithub:mainfrom
aschackmull:java/fix-csv-dispatch
Jul 19, 2021
Merged

Java: Fix a bug in call-context-sensitve dispatch to SummarizedCallable.#6313
aschackmull merged 1 commit intogithub:mainfrom
aschackmull:java/fix-csv-dispatch

Conversation

@aschackmull
Copy link
Copy Markdown
Contributor

Call-context-sensitve dispatch failed to account for SummarizedCallable.

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Jul 16, 2021
@aschackmull aschackmull requested a review from a team as a code owner July 16, 2021 12:32
@github-actions github-actions bot added the Java label Jul 16, 2021
@smowton
Copy link
Copy Markdown
Contributor

smowton commented Jul 16, 2021

Can a test be pulled out of the failing case shown by @sauyon?

@aschackmull
Copy link
Copy Markdown
Contributor Author

Can a test be pulled out of the failing case shown by @sauyon?

The circumstances required to reproduce this are pretty involved, so I don't think the test case can be reduced much further. When we merge #5953 we'll have coverage for this, so I don't think we need to try to add an explicit test on this PR.

Copy link
Copy Markdown
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

@aschackmull aschackmull merged commit db76b12 into github:main Jul 19, 2021
@aschackmull aschackmull deleted the java/fix-csv-dispatch branch July 19, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants