Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44608: Fix memory leak in _tkinter._flatten() #27107

Merged
merged 4 commits into from Jul 14, 2021

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 13, 2021

if it is called with a sequence or set, but not list or tuple.

https://bugs.python.org/issue44608

if it is called with a sequence or set, but not list or tuple.
@@ -649,17 +661,37 @@ def test_or_types_operator(self):
3 | int
with self.assertRaises(TypeError):
Example() | int
x = int | str
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidentally copied over these tests from another branch 😅 . They seem to be for another bug.

@serhiy-storchaka serhiy-storchaka merged commit f572cbf into python:main Jul 14, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 14, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒🤖

@serhiy-storchaka serhiy-storchaka deleted the tkinter-flatten-leak branch Jul 14, 2021
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 14, 2021

GH-27133 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 14, 2021
if it is called with a sequence or set, but not list or tuple.
(cherry picked from commit f572cbf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 14, 2021

GH-27134 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 14, 2021
if it is called with a sequence or set, but not list or tuple.
(cherry picked from commit f572cbf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this issue Jul 14, 2021
if it is called with a sequence or set, but not list or tuple.
(cherry picked from commit f572cbf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this issue Jul 14, 2021
if it is called with a sequence or set, but not list or tuple.
(cherry picked from commit f572cbf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
if it is called with a sequence or set, but not list or tuple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants