C#: Remove redundant conjunct in ssaDefReachesReadWithinBlock#6293
Merged
hvitved merged 1 commit intogithub:mainfrom Jul 16, 2021
Merged
C#: Remove redundant conjunct in ssaDefReachesReadWithinBlock#6293hvitved merged 1 commit intogithub:mainfrom
ssaDefReachesReadWithinBlock#6293hvitved merged 1 commit intogithub:mainfrom
Conversation
tamasvajk
approved these changes
Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attention was drawn to this predicate because of a bad join-order
where
ssaDefReachesRankandvariableReadwere joined on justbbandv. It turns out that thevariableRead(bb, i, v, _)conjunct is actually not needed, since it is implied byssaRefRank(bb, i, v, SsaRead()). Removing the conjunct therefore both simplifies the logic, and improves the join order:https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/1203/