Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44535: Enable building with Visual Studio 2022 on Windows #26962

Merged
merged 1 commit into from Jun 30, 2021
Merged

bpo-44535: Enable building with Visual Studio 2022 on Windows #26962

merged 1 commit into from Jun 30, 2021

Conversation

@zooba
Copy link
Member

@zooba zooba commented Jun 30, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44535
@zooba
bpo-44535: Enable building with Visual Stuio 2022 on Windows
17d1562
@zooba zooba requested a review from python/windows-team as a code owner Jun 30, 2021
@zooba
Copy link
Member Author

@zooba zooba commented Jun 30, 2021

Note that there's a typo in the commit message, which will need to be fixed before merging (unless another commit is added, though that seems unlikely).
@zooba zooba merged commit d3a95c1 into python:main Jun 30, 2021
13 checks passed
13 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210630.7 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44535 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 30, 2021

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
@zooba zooba deleted the zooba:bpo-44535 branch Jun 30, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 30, 2021

Sorry @zooba, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d3a95c1b6eacbbbd92c294744e7ed41932f3f63e 3.10
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 30, 2021
@zooba @miss-islington
bpo-44535: Enable building with Visual Studio 2022 on Windows (python…
d13d7b5 
…GH-26962)

(cherry picked from commit d3a95c1)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 30, 2021

GH-26975 is a backport of this pull request to the 3.9 branch.
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 30, 2021

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 30, 2021

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 30, 2021
@zooba @miss-islington
bpo-44535: Enable building with Visual Studio 2022 on Windows (python…
97e2dc8 
…GH-26962)

(cherry picked from commit d3a95c1)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 30, 2021

GH-26976 is a backport of this pull request to the 3.10 branch.
miss-islington added a commit that referenced this pull request Jun 30, 2021
@miss-islington @zooba
bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962)
6843a3b 
(cherry picked from commit d3a95c1)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Jun 30, 2021
@miss-islington @zooba
bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962)
67e3945 
(cherry picked from commit d3a95c1)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees

@zooba zooba

Labels
CLA signed OS-windows needs backport to 3.9
Projects
None yet
Milestone
No milestone
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni