Java: Reduce DataFlow Configuration pollution from Random.qll and JexlInjection.qll#6203
Merged
smowton merged 6 commits intogithub:mainfrom Jul 2, 2021
Conversation
aschackmull
previously approved these changes
Jul 2, 2021
Contributor
|
atorralba
reviewed
Jul 2, 2021
| import semmle.code.java.security.JexlInjectionQuery | ||
| import TestUtilities.InlineExpectationsTest | ||
|
|
||
| class Conf extends TaintTracking::Configuration { |
Contributor
There was a problem hiding this comment.
This configuration can be removed now, since the one in JexlInjectionQuery can be reused.
aschackmull
previously approved these changes
Jul 2, 2021
This prevents bringing a dataflow config into scope from utility libraries.
This avoids a DataFlow2::Configuration being in scope for all queries via the import from ExternalFlow.qll
This removes one of the routes by which XSS.qll is always in scope, and so its dataflow configuration is too -- however it is still always in scope because JaxWS.qll imports it.
666d8d9 to
a51154a
Compare
aschackmull
approved these changes
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits
Random.qll,JexlInjection.qlland some ofXSS.qllinto parts used by queries and those imported by other libraries, in order to avoid bringing DataFlow::Configurations into scope except directly from a.qlfile.