Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] bpo-44022: Improve the regression test. (GH-26503) #26508

Merged
merged 1 commit into from Jun 3, 2021
Merged

[3.6] bpo-44022: Improve the regression test. (GH-26503) #26508

merged 1 commit into from Jun 3, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 3, 2021 •
edited by bedevere-bot

It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab84)

Co-authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue44022
@gpshead @miss-islington
bpo-44022: Improve the regression test. (GH-26503)
737601b 
It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab84)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot mentioned this pull request Jun 3, 2021
Merged
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Jun 3, 2021

@gpshead: Status check is done, and it's a success ✅ .
@gpshead
gpshead approved these changes Jun 3, 2021
View changes
@ned-deily ned-deily merged commit 1b6f4e5 into python:3.6 Jun 3, 2021
4 of 5 checks passed
4 of 5 checks passed
Azure Pipelines PR in progress
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44022 found
Details
@bedevere-bot
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington miss-islington deleted the miss-islington:backport-e60ab84-3.6 branch Jun 3, 2021
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Jun 3, 2021

@gpshead: Status check is done, and it's a failure ❌ .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees

@ned-deily ned-deily

Labels
CLA signed skip news type-security type-tests
Projects
None yet
Milestone
No milestone
5 participants
@miss-islington @gpshead @ned-deily @the-knights-who-say-ni @bedevere-bot