Cannot build devguide in virtual environment on Windows #267
Comments
|
Have a look at what cpython's Doc/make.bat does, I think it's in better shape than this make.bat is at this point. |
|
@zware Thanks. There are some interesting things there, but not the use of a virtual environment. I'm aiming for as much like the Makefile as possible and otherwise minimum change. ( I take the hint from this conditional however that if you've defined your own command in SPHINXBUILD we should butt out with our venv. |
|
Ah, you're right; we haven't added venv support to Doc/make.bat. Sorry for the red herring :( Yes, if SPHINXBUILD is set, we should assume the user knows what they're doing and just go with it. Otherwise, I like your plan of trying to match Makefile's behavior as closely as possible. |
Add to the Windows build script a clause to create and use a virtual environment and install Sphinx there, comparable with the Unix Makefile. The user may suppress this behaviour by defining a her preferred command in the environment variable SPHINXBUILD, as before.
* Build in a virtual environment on Windows (GH-267) Add to the Windows build script a clause to create and use a virtual environment and install Sphinx there, comparable with the Unix Makefile. The user may suppress this behaviour by defining a her preferred command in the environment variable SPHINXBUILD, as before. * Simplify wording and add comment following review. * Always build relative to the directory containing make.bat Whatever the current directory when invoked, the build takes place into _build/... in the directory that contains make.bat, and returns to the invocation directory. * Properly escape parentheses in the help text. Previously this disabled subsequent build targets by making "goto end" accidentally unconditional. We also describe the "check" target.
|
Resolved in #268. |
On Windows
make htmldoes nothing.There are several problems here:
gotoinside parenthes. Yeah, it ought to work but it doesn't reliably. In fact, it stops the action dead.I think that with problem 1 fixed, one could build by installing Sphinx site-wide, but I'd like to follow the sensible advice in section 6.3, and use a virtual environment.
I'll propose you a fix in due course, as much like the Unix Makefile as I can.
The text was updated successfully, but these errors were encountered: