Make gather an optional component #9755
Conversation
…nto dev/jim/use-new-gather
cell executionId for gather.
…nto dev/jim/use-new-gather
…nto dev/jim/use-new-gather
and interfaces
Dynamically look for python-program-analysis. If not there gather is unsupported.
src/client/datascience/jupyter/liveshare/hostJupyterNotebook.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@rchiodo @greazer
I don't know much about gather now how it works/what it does.
Looking at the code, the gather needs to be tied to a specific notebook, and we do this by using some hops by using IInteractiveWindowListener, then going through all listeners and finding the specific item and casting to a type, then getting something out of that (service property, etc). This seems quite complicated to me.
Shouldn't we have a better way to tie these instances to a specific notebook.
I.e. either each class maintains its own collection of objects against notebooks (its own map/dict). Then ensure we pass the notebook uri (Interactive Window/Native Editor) objects to some of these interfaces, such as ICellHashListener and ICellHashProvider.
…/vscode-python into dev/jim/use-new-gather
|
Kudos, SonarCloud Quality Gate passed!
|
This PR does two things. First, it modifies the building of gather functionality to make use of a non OSS component. Second, it adjusts the existing CellHash management to be per-notebook rather than a singleton. Both of the above were related, so it made sense to do it in one PR.
Has a news entry file (remember to thank yourself!)Has telemetry for enhancements.Coming in subsequent PR.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)