Expand no unused vars rule#15704
Merged
kimadeline merged 2 commits intomicrosoft:mainfrom Mar 19, 2021
Merged
Conversation
karrtikr
approved these changes
Mar 19, 2021
karrtikr
reviewed
Mar 19, 2021
karthiknadig
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amend the @typescript-eslint/no-unused-vars rule to ignore all unused positional arguments that start with an underscore and are placed after the last used argument (see the description here). This also means that we don't need to add an ignore directive for code like this anymore:
Cleaned up the 44
no-unused-varsignore comments in the codebase as well.