bpo-42972: Track sqlite3 statement objects #26475
Merged
+40
−48
Conversation
|
cc. @vstinner |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
By allocating and tracking creation of statement object in pysqlite_statement_create(), the caller does not need to worry about GC syncronization, and eliminates the possibility of getting a badly created object. All related fault handling is moved to pysqlite_statement_create().
|
LGTM, but I would like to see the minor issues being addressed first before merging your change. |
ee00a0d
to
6b1ea0c
Co-authored-by: Victor Stinner <vstinner@python.org>
6b1ea0c
to
4f03b79
|
LGTM. |
fffa0f9
into
python:main
11 checks passed
11 checks passed
bedevere/news
"skip news" label found
|
Merged, thanks. |
Thanks for reviewing, Victor & Pablo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://bugs.python.org/issue42972