Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43693: Add _PyCode_New(). #26375

Merged
merged 8 commits into from May 27, 2021
Merged

bpo-43693: Add _PyCode_New(). #26375

merged 8 commits into from May 27, 2021

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented May 26, 2021 •
edited

This is an internal-only API that helps us manage the many values used to create a code object.

https://bugs.python.org/issue43693
@ericsnowcurrently ericsnowcurrently requested a review from markshannon May 26, 2021
@ericsnowcurrently ericsnowcurrently requested a review from tiran as a code owner May 26, 2021
@ericsnowcurrently ericsnowcurrently removed the request for review from tiran May 26, 2021
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 26, 2021
Closed
@ericsnowcurrently ericsnowcurrently force-pushed the ericsnowcurrently:code-object-cleanup-new branch 2 times, most recently from 2cd8dfb to 9bcbbea May 26, 2021
@ericsnowcurrently
Add _PyCode_New().
974cb91
@ericsnowcurrently
Check nplainlocals instead of totalargs.
e4387e4
@ericsnowcurrently
Add _PyCode_Validate().
7e3a247
@ericsnowcurrently
Drop nlocals from marshaled code objects.
c310d7c
@ericsnowcurrently
Fix test_ctypes.
fa5d83e
@ericsnowcurrently
Stop using statics in PyCode_NewEmpty().
e356588
@ericsnowcurrently ericsnowcurrently force-pushed the ericsnowcurrently:code-object-cleanup-new branch from a466357 to e356588 May 26, 2021
This was referenced May 26, 2021
Open
Open
@markshannon
markshannon reviewed May 27, 2021
View changes
Objects/codeobject.c Outdated Show resolved Hide resolved
@markshannon
markshannon reviewed May 27, 2021
View changes
Objects/codeobject.c Outdated Show resolved Hide resolved
@markshannon
Copy link
Contributor

@markshannon markshannon commented May 27, 2021

Just a couple of minor issues.
@ericsnowcurrently
Drop "inline" from a big function.
f2b227a
@ericsnowcurrently
Fail if there was an error.
b36ca68
@markshannon
Copy link
Contributor

@markshannon markshannon commented May 27, 2021

LGTM 👍
@ericsnowcurrently ericsnowcurrently merged commit 9f494d4 into python:main May 27, 2021
11 checks passed
11 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
Azure Pipelines PR #20210527.19 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 43693 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@ericsnowcurrently ericsnowcurrently deleted the ericsnowcurrently:code-object-cleanup-new branch May 27, 2021
@markshannon markshannon mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@ericsnowcurrently @markshannon @the-knights-who-say-ni @bedevere-bot