Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-44022: Fix http client infinite line reading (DoS) after a HTTP 100 Continue (GH-25916) #25933

Merged
merged 1 commit into from May 6, 2021
Merged

[3.8] bpo-44022: Fix http client infinite line reading (DoS) after a HTTP 100 Continue (GH-25916) #25933

merged 1 commit into from May 6, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 5, 2021 •
edited

Fixes http.client potential denial of service where it could get stuck reading lines from a malicious server after a 100 Continue response.

Co-authored-by: Gregory P. Smith greg@krypto.org
(cherry picked from commit 47895e3)

Co-authored-by: Gen Xu xgbarry@gmail.com

https://bugs.python.org/issue44022

Automerge-Triggered-By: GH:gpshead

@gen-xu @miss-islington
bpo-44022: Fix http client infinite line reading (DoS) after a HTTP 1…
e73c448 
…00 Continue (pythonGH-25916)

Fixes http.client potential denial of service where it could get stuck reading lines from a malicious server after a 100 Continue response.

Co-authored-by: Gregory P. Smith <greg@krypto.org>
(cherry picked from commit 47895e3)

Co-authored-by: Gen Xu <xgbarry@gmail.com>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 5, 2021

@gen-xu and @gpshead: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 5, 2021
Merged
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 5, 2021

@gen-xu and @gpshead: Status check is done, and it's a success ✅ .

gpshead
gpshead approved these changes May 5, 2021
View changes
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 5, 2021

@gen-xu and @gpshead: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 5, 2021

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@ambv ambv merged commit f396864 into python:3.8 May 6, 2021
14 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 6, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-47895e3-3.8 branch May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees

@ambv ambv

Labels
CLA signed 🤖 automerge type-bugfix type-security
Projects
None yet
Milestone
No milestone
6 participants
@miss-islington @bedevere-bot @gpshead @ambv @the-knights-who-say-ni @gen-xu