Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in configure #26078

Merged
merged 1 commit into from May 13, 2021
Merged

Fix typo in configure #26078

merged 1 commit into from May 13, 2021
+1 −1

Conversation

@eltociear
Copy link
Contributor

@eltociear eltociear commented May 12, 2021

hte -> the
@eltociear
Fix typo in configure
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
a90c00e 
hte -> the
@NAPADAI
Copy link

@NAPADAI NAPADAI commented May 12, 2021

configure
@NAPADAI
Copy link

@NAPADAI NAPADAI commented May 12, 2021

configure
@UriyaHarpeness
UriyaHarpeness approved these changes May 13, 2021
View changes
@corona10
corona10 approved these changes May 13, 2021
View changes
Copy link
Member

@corona10 corona10 left a comment

lgtm
@corona10 corona10 self-assigned this May 13, 2021
@corona10 corona10 merged commit 3c0b070 into python:main May 13, 2021
13 checks passed
13 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Ubuntu SSL tests with OpenSSL (1.1.1k)
Details
@github-actions
Ubuntu SSL tests with OpenSSL (3.0.0-alpha16)
Details
Azure Pipelines PR #20210512.44 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue report skipped
@bedevere-bot
bedevere/news "skip news" label found
@ned-deily
Copy link
Member

@ned-deily ned-deily commented May 13, 2021 •
edited

@corona10, FYI, this PR Is incomplete. configure is a file generated from configure.ac using autoreconf. When making changes, you need to change configure.ac first, then run autoreconf, then check-in the changes to both files. We maintain configure as a checked-in file for convenience so people don't have to run autoreconf themselves when changes to configure.ac are made. If you don't change configure.ac, the change made just to configure will likely be lost the next time a change to configure.ac (and thus configure) is made. The Dev Guide has more info: https://devguide.python.org/setup/#regenerate-configure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@UriyaHarpeness UriyaHarpeness

Assignees

@corona10 corona10

Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
7 participants
@eltociear @NAPADAI @ned-deily @corona10 @UriyaHarpeness @the-knights-who-say-ni @bedevere-bot