Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc as relative import can be used with star import #25667

Merged
merged 1 commit into from May 14, 2021
Merged

Update doc as relative import can be used with star import #25667

merged 1 commit into from May 14, 2021

Conversation

gousaiyang
Copy link
Contributor

@gousaiyang gousaiyang commented Apr 27, 2021

Update "The import statement" documentation section as from .mod import * is valid.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 27, 2021
JelleZijlstra
JelleZijlstra approved these changes May 4, 2021
View changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

This seems right. Even from . import * works at runtime.

@willingc
Copy link
Sponsor Contributor

willingc commented May 14, 2021

Thanks @gousaiyang for the PR and @JelleZijlstra for the review.

@willingc willingc merged commit 3d4b5f1 into python:main May 14, 2021
12 checks passed
@gousaiyang gousaiyang deleted the doc-from-relative-mod-import-star branch May 14, 2021
@gousaiyang
Copy link
Contributor Author

gousaiyang commented May 14, 2021

Could we backport this PR at least down to 3.9? The doc on the main branch will only be visible in 3.11, while from .mod import * has been valid in Python for a long time ever since Python 2.6.

@miss-islington
Copy link
Contributor

miss-islington commented May 14, 2021

Thanks @gousaiyang for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 14, 2021

Thanks @gousaiyang for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 14, 2021

GH-26121 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2021
@gousaiyang @miss-islington
Update doc as relative import can be used with star import (pythonGH-…
f2a230c 
…25667)

(cherry picked from commit 3d4b5f1)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@bedevere-bot
Copy link

bedevere-bot commented May 14, 2021

GH-26122 is a backport of this pull request to the 3.9 branch.

orsenthil pushed a commit that referenced this pull request May 14, 2021
@miss-islington @gousaiyang
Update doc as relative import can be used with star import (GH-25667) (…
f3007ea 
…GH-26122)

(cherry picked from commit 3d4b5f1)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
orsenthil pushed a commit that referenced this pull request May 14, 2021
@miss-islington @gousaiyang
Update doc as relative import can be used with star import (GH-25667) (…
8940916 
…GH-26121)

(cherry picked from commit 3d4b5f1)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gousaiyang @willingc @miss-islington @bedevere-bot @JelleZijlstra @the-knights-who-say-ni