Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-28146: Fix a confusing error message in str.format() #24213

Merged
merged 2 commits into from May 13, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 13, 2021

https://bugs.python.org/issue28146

Automerge-Triggered-By: GH:pitrou

@github-actions
Copy link

github-actions bot commented Feb 13, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 13, 2021
pitrou
pitrou approved these changes May 13, 2021
Copy link
Member

@pitrou pitrou left a comment

This looks like a small but obvious improvement.

@pitrou pitrou added 🤖 automerge PR will be merged once it's been approved and all CI passed and removed stale Stale PR or inactive for long period of time. labels May 13, 2021
@miss-islington
Copy link
Contributor

miss-islington commented May 13, 2021

@iritkatriel: Status check is done, and it's a success .

@miss-islington miss-islington merged commit 4aeee0b into python:main May 13, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 13, 2021

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 13, 2021

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2021
)

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 4aeee0b)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@bedevere-bot
Copy link

bedevere-bot commented May 13, 2021

GH-26110 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

miss-islington commented May 13, 2021

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2021
)

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 4aeee0b)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@bedevere-bot
Copy link

bedevere-bot commented May 13, 2021

GH-26111 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2021
)

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 4aeee0b)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@bedevere-bot
Copy link

bedevere-bot commented May 13, 2021

GH-26112 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request May 13, 2021
Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 4aeee0b)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
miss-islington added a commit that referenced this pull request May 13, 2021
Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 4aeee0b)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@iritkatriel iritkatriel deleted the bpo-28146 branch Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants