Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subprocess Protocols Documentation #20950

Merged
merged 1 commit into from May 14, 2021
Merged

Subprocess Protocols Documentation #20950

merged 1 commit into from May 14, 2021

Conversation

kudavid
Copy link
Contributor

@kudavid kudavid commented Jun 17, 2020

Should be "Subprocess Protocol instances" not "Datagram Protocol instances"

@kudavid
Subprocess Protocols Documentation
346736b 
Should be "Subprocess Protocol instances" not "Datagram Protocol instances"
@kudavid kudavid requested review from 1st1 and asvetlov as code owners Jun 17, 2020
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jun 17, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@kudavid

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 17, 2020
eamanu
eamanu approved these changes Jun 17, 2020
View changes
Copy link
Contributor

@eamanu eamanu left a comment •
edited

good catch, please sign CLA.

@csabella
Copy link
Contributor

csabella commented Sep 21, 2020

@kudavid, please sign the CLA. Thank you!

1st1
1st1 approved these changes Sep 21, 2020
View changes
@1st1 1st1 closed this Sep 21, 2020
@1st1 1st1 reopened this Sep 21, 2020
@orsenthil orsenthil merged commit 2918846 into python:main May 14, 2021
4 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 14, 2021

Thanks @kudavid for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 14, 2021

GH-26133 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2021
@kudavid @miss-islington
Subprocess Protocols Documentation (pythonGH-20950)
b6148c0 
Should be "Subprocess Protocol instances" not "Datagram Protocol instances"
(cherry picked from commit 2918846)

Co-authored-by: kudavid <67070184+kudavid@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented May 14, 2021

GH-26134 is a backport of this pull request to the 3.9 branch.

orsenthil pushed a commit that referenced this pull request May 14, 2021
@miss-islington
Subprocess Protocols Documentation (GH-20950) (GH-26133)
623481c
orsenthil pushed a commit that referenced this pull request May 14, 2021
@miss-islington @kudavid
Subprocess Protocols Documentation (GH-20950) (GH-26134)
41ed452 
Should be "Subprocess Protocol instances" not "Datagram Protocol instances"
(cherry picked from commit 2918846)

Co-authored-by: kudavid <67070184+kudavid@users.noreply.github.com>

Co-authored-by: kudavid <67070184+kudavid@users.noreply.github.com>
@orsenthil
Copy link
Member

orsenthil commented May 14, 2021

@kudavid A simple improvement, but please sign the CLA. I realized it was not signed only after the merge.
This is only a one word change, but still keeps the records clean. Thank you.

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

@eamanu eamanu

@asvetlov asvetlov

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet