Ruby: ignore RuboCop remote inherited config files #3197
Merged
Conversation
|
@sshaw thanks! |
tokuhira
added a commit
to tokuhira/gitignore
that referenced
this pull request
Dec 16, 2019
r2pgl
added a commit
to r2pgl/gitignore
that referenced
this pull request
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reasons for making this change:
RuboCop config files support an
inherit_fromdirective.When one inherits from a remote URL, a local version is download. For example:
.rubocop-https--my-remote-config.com.Links to documentation supporting these rule changes:
From RuboCop's docs
Given this, is seems appropriate for git to ignore this file.