Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Smalltalk] add support for Dolphin Smalltalk #2027

Merged
merged 1 commit into from Nov 23, 2018
Merged

Conversation

@rejurime
Copy link
Contributor

@rejurime rejurime commented Jun 28, 2016

Reasons for making this change:

Add support to Dolphin Smalltalk, the template only have support to Pharo and Squeak.

Links to documentation supporting these rule changes:


# Pharo Smalltalk Debug log file
PharoDebug.log

# Squeak Smalltalk Debug log file
SqueakDebug.log

# Dolphin Smalltalk source file
*.sml

This comment has been minimized.

@shiftkey

shiftkey Jan 29, 2017
Member

It's not clear to me that these source files can be safely ignored. Do you have any links to documentation or discussion about these files?

This comment has been minimized.

@rejurime

rejurime Feb 6, 2017
Author Contributor

The Dolphin Smalltalk 7 fresh image is composed of 3 files:

  • ImageName.chg
  • ImageName.sml
  • ImageName.img7

Then you create a Package where your own code is store and the package is what you have to version.

This comment has been minimized.

@rejurime

rejurime Feb 6, 2017
Author Contributor

This can help https://github.com/dolphinsmalltalk/Contributions the official contribution repository.

This comment has been minimized.

@rejurime

rejurime Feb 9, 2017
Author Contributor

Here you can see gitignore in the official repository of Dolphin Smalltalk.
https://github.com/dolphinsmalltalk/Dolphin/blob/master/.gitignore

@@ -1,15 +1,24 @@
# changes file
*.changes
*.chg

This comment has been minimized.

@shiftkey

shiftkey Jan 29, 2017
Member

Same thing with these extensions - can you tell me about what they represent and why they can be safely ignored? Additional resources are definitely helpful here!

This comment has been minimized.

@rejurime

rejurime Feb 6, 2017
Author Contributor

Represents the same as in Pharo and Squeak (.changes).
When you save something (ctrl+s) this change is add to the chg file, everything you modify is added. This file is complemented by SML and IMG/IMG7 to create the complete image, but what is important to version are the code packages (
.pac or *.pax - *.cls)

@shiftkey shiftkey removed the new template label Jan 29, 2017
@shiftkey shiftkey changed the title Add support for Dolphin Smalltalk [Smalltalk] add support for Dolphin Smalltalk Jan 29, 2017
@rejurime
Copy link
Contributor Author

@rejurime rejurime commented Jul 13, 2017

Hi @shiftkey do you need more information about this changes?

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Nov 23, 2018

@rejurime no, I'm good. Thanks for working through it with me!

@shiftkey shiftkey merged commit 5ec4476 into github:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants