Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44018: random.seed() no longer mutates its inputs #25856

Merged
merged 1 commit into from May 3, 2021
Merged

bpo-44018: random.seed() no longer mutates its inputs #25856

merged 1 commit into from May 3, 2021

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented May 3, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44018
@rhettinger rhettinger merged commit b05352e into python:main May 3, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 3, 2021

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue May 3, 2021
@rhettinger @miss-islington
bpo-44018: random.seed() no longer mutates its inputs (pythonGH-25856)
0bb5756 
(cherry picked from commit b05352e)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 3, 2021

GH-25864 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue May 3, 2021
@rhettinger @miss-islington
bpo-44018: random.seed() no longer mutates its inputs (pythonGH-25856)
62733e0 
(cherry picked from commit b05352e)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 3, 2021

GH-25865 is a backport of this pull request to the 3.8 branch.

rhettinger pushed a commit that referenced this issue May 3, 2021
@miss-islington
bpo-44018: random.seed() no longer mutates its inputs (GH-25856) (GH-…
e733e99 
…25864)
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 4, 2021

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue May 4, 2021
@rhettinger @miss-islington
bpo-44018: random.seed() no longer mutates its inputs (pythonGH-25856)
9570735 
(cherry picked from commit b05352e)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 4, 2021

GH-25872 is a backport of this pull request to the 3.10 branch.

@python python deleted a comment from bedevere-bot May 4, 2021
@python python deleted a comment from miss-islington May 4, 2021
rhettinger pushed a commit that referenced this issue May 4, 2021
@miss-islington
bpo-44018: random.seed() no longer mutates its inputs (GH-25856) (GH-…
2995bff 
…25872)
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 4, 2021 •
edited

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Non-Debug 3.10 has failed when building commit 2995bff.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/618/builds/3) and take a look at the build logs.
  4. Check if the failure is related to this commit (2995bff) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/618/builds/3

Failed tests:

  • test_compile

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 1        
remote: Enumerating objects: 6, done.        
remote: Counting objects:  16% (1/6)        
remote: Counting objects:  33% (2/6)        
remote: Counting objects:  50% (3/6)        
remote: Counting objects:  66% (4/6)        
remote: Counting objects:  83% (5/6)        
remote: Counting objects: 100% (6/6)        
remote: Counting objects: 100% (6/6), done.        
remote: Compressing objects:  33% (1/3)        
remote: Compressing objects:  66% (2/3)        
remote: Compressing objects: 100% (3/3)        
remote: Compressing objects: 100% (3/3), done.        
remote: Total 6 (delta 3), reused 3 (delta 3), pack-reused 0        
From https://github.com/python/cpython
 * branch                  3.10       -> FETCH_HEAD
Note: switching to '2995bff4269d274c0a3abfd45dc33b28f0c3e25f'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 2995bff426 [bpo-44018](https://bugs.python.org/issue44018): random.seed() no longer mutates its inputs (GH-25856) (GH-25872)
Switched to and reset branch '3.10'

test_startfile skipped -- object <module 'os' from '/usr/home/buildbot/python/3.10.koobs-freebsd-9e36.nondebug/build/Lib/os.py'> has no attribute 'startfile'
test_ttk_textonly skipped -- No module named '_tkinter'
test_tcl skipped -- No module named '_tkinter'
test_badargs (__main__.GeneralTest) ... ok
test_bound_methods (__main__.GeneralTest) ... ok
test_clear (__main__.GeneralTest) ... ok
test_exit (__main__.GeneralTest) ... ok
test_order (__main__.GeneralTest) ... ok
test_raise (__main__.GeneralTest) ... ok
test_raise_unnormalized (__main__.GeneralTest) ... ok
test_stress (__main__.GeneralTest) ... ok
test_unregister (__main__.GeneralTest) ... ok

----------------------------------------------------------------------
Ran 9 tests in 0.006s

OK
test_ioctl skipped -- Unable to open /dev/tty
test_msilib skipped -- No module named '_msi'
test_tk skipped -- No module named '_tkinter'
test_turtle skipped -- No module named '_tkinter'
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_readline skipped -- No module named 'readline'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_ttk_guionly skipped -- No module named '_tkinter'
test_tix skipped -- No module named '_tkinter'
test_dbm_gnu skipped -- No module named '_gdbm'
test_winconsoleio skipped -- test only relevant on win32
test_winsound skipped -- No module named 'winsound'
test_winreg skipped -- No module named 'winreg'
test_idle skipped -- No module named '_tkinter'
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... skipped 'need select.epoll'
test_kqueue (__main__.SelectEINTRTest) ... ok
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 7.136s

OK (skipped=2)
test_devpoll skipped -- test works only on Solaris OS family
test_spwd skipped -- No module named 'spwd'
test_epoll skipped -- test works only on Linux 2.6
/tmp/tmp38i6ypyw/parse.c:140:19: warning: code will never be executed [-Wunreachable-code]
        p->mark = _mark;
                  ^~~~~
1 warning generated.

Cannot open file '/usr/home/buildbot/python/3.10.koobs-freebsd-9e36.nondebug/build/test-results.xml' for upload

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
6 participants
@rhettinger @miss-islington @bedevere-bot @serhiy-storchaka @pablogsal @the-knights-who-say-ni