Created on 2021-05-01 17:15 by Jelle Zijlstra, last changed 2021-05-05 10:04 by kj. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 25877 | merged | Jelle Zijlstra, 2021-05-04 04:05 | |
| PR 25882 | merged | miss-islington, 2021-05-04 08:54 | |
| PR 25897 | merged | Jelle Zijlstra, 2021-05-04 16:04 | |
| Messages (5) | |||
|---|---|---|---|
| msg392608 - (view) | Author: Jelle Zijlstra (Jelle Zijlstra) *  |
Date: 2021-05-01 17:15 | |
After the changes from bpo-42345, the Literal documentation claims that "Literal objects will now raise a TypeError exception during equality comparisons if one of their parameters are not immutable." But in fact it's *unhashable* types that raise an error; mutable but hashable types such as functions or custom objects work fine. I'll submit a PR for this but may wait until GH-25787 is resolved. |
|||
| msg392867 - (view) | Author: Łukasz Langa (lukasz.langa) *  |
Date: 2021-05-04 09:17 | |
New changeset 2046fb35e4e0986523bd0f6214fc318a414c8b97 by Miss Islington (bot) in branch '3.10': bpo-44001: improve Literal documentation (GH-25877) (#25882) https://github.com/python/cpython/commit/2046fb35e4e0986523bd0f6214fc318a414c8b97 |
|||
| msg392908 - (view) | Author: Ken Jin (kj) * |
Date: 2021-05-04 15:07 | |
Jelle, thanks for fixing up the docs. You're right here - anything that can be an element in a frozenset or used as a key in a dict works. And the current docs for sets says that means anything hashable: https://docs.python.org/3/library/stdtypes.html#set-types-set-frozenset If you feel anything's amiss. Please don't hesitate to re-open this issue. |
|||
| msg392914 - (view) | Author: Ken Jin (kj) * |
Date: 2021-05-04 16:09 | |
Well something was amiss: the 3.9 backport PR ;-). Sorry for closing this issue too early. I didn't notice there was still one more to go. |
|||
| msg392917 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-05-04 16:48 | |
New changeset ab0a54adad8ddf488ccfb92970be9e4027673d19 by Jelle Zijlstra in branch '3.9': [3.9] bpo-44001: improve Literal documentation (GH-25877). (#25897) https://github.com/python/cpython/commit/ab0a54adad8ddf488ccfb92970be9e4027673d19 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2021-05-05 10:04:22 | kj | set | status: open -> closed resolution: fixed |
| 2021-05-04 16:48:49 | lukasz.langa | set | messages: + msg392917 |
| 2021-05-04 16:09:14 | kj | set | status: closed -> open resolution: fixed -> (no value) messages: + msg392914 |
| 2021-05-04 16:04:48 | Jelle Zijlstra | set | pull_requests: + pull_request24569 |
| 2021-05-04 15:07:43 | kj | set | status: open -> closed nosy: + kj messages: + msg392908 resolution: fixed stage: patch review -> resolved |
| 2021-05-04 09:17:38 | lukasz.langa | set | nosy:
+ lukasz.langa messages: + msg392867 |
| 2021-05-04 08:54:22 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request24557 |
| 2021-05-04 04:05:32 | Jelle Zijlstra | set | keywords:
+ patch stage: patch review pull_requests: + pull_request24554 |
| 2021-05-01 17:15:22 | Jelle Zijlstra | create | |