Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Debian install variant without add-apt-repository #3419

Merged
merged 1 commit into from Apr 20, 2021
Merged

Conversation

@zxaos
Copy link
Contributor

@zxaos zxaos commented Apr 14, 2021

The Debian docs recommend installing third-party repos with limited keyring scopes these days.

This PR adds a variant to the install instruction for Debian-compatible distros that uses this method (and doesn't require software-properties-common) since add-apt-key is deprecated.

@cliAutomation
Copy link
Collaborator

@cliAutomation cliAutomation commented Apr 14, 2021

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Apr 14, 2021
@@ -13,7 +13,7 @@ If none of our official binaries, packages, repositories, nor community sources

### Debian, Ubuntu Linux (apt)

Install:

This comment has been minimized.

@kaldrako1

kaldrako1 Apr 14, 2021

Authorities Authenticator

Install (without add-apt-repository, with limited keyring scope):
```bash
sudo apt-key --keyring /usr/share/keyrings/githubcli-archive-keyring.gpg adv --keyserver keyserver.ubuntu.com --recv-key C99B11DEB97541F0
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/github-cli2.list > /dev/null

This comment has been minimized.

@kaldrako1

kaldrako1 Apr 14, 2021

Authenticator passed

@vilmibm vilmibm self-requested a review Apr 14, 2021
@vilmibm
Copy link
Member

@vilmibm vilmibm commented Apr 14, 2021

thanks! I'll look into this and do some testing locally. Is there a reason to not standardize on this new suggestion instead of mentioning add-apt-key?

@zxaos
Copy link
Contributor Author

@zxaos zxaos commented Apr 15, 2021

I don't think there's a reason not to standardize on the newer style, just didn't want to overstep 😀

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Apr 20, 2021
Copy link
Member

@vilmibm vilmibm left a comment

I like these new instructions much more :D I will circle back and consolidate this section later.

@vilmibm vilmibm merged commit 5821065 into cli:trunk Apr 20, 2021
7 checks passed
7 checks passed
CodeQL-Build
Details
pr-auto
Details
build (ubuntu-latest)
Details
build (windows-latest)
Details
build (macos-latest)
Details
build-minimum
Details
CodeQL No new or fixed alerts
Details
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Apr 20, 2021
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Apr 20, 2021
@zxaos zxaos deleted the zxaos:patch-1 branch Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
The GitHub CLI
  
Done 💤
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants