Skip to content

/ openpilot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator CI test #2572

Open
adeebshihadeh opened this issue Nov 18, 2020 · 6 comments
Open

Simulator CI test #2572

adeebshihadeh opened this issue Nov 18, 2020 · 6 comments
Labels
CI good first issue simulation

Comments

@adeebshihadeh
Copy link
Contributor

@adeebshihadeh adeebshihadeh commented Nov 18, 2020

The test should run openpilot in the simulator for a minute and fail on process crashes or unexpected alerts. Ideally, this test should be able to run in GitHub Actions.
@ekdnam
Copy link

@ekdnam ekdnam commented Nov 21, 2020

I would love to work on the issue. Can you assign me?
@geohot
Copy link
Contributor

@geohot geohot commented Nov 24, 2020

No assignment required, just submit a PR!
@ekdnam
Copy link

@ekdnam ekdnam commented Nov 25, 2020

Okay sure! Can someone give a few guidelines on how to solve the issue? I am new to testing, and would love to get some insights on how to proceed
@grekiki
Copy link
Contributor

@grekiki grekiki commented Nov 27, 2020

First get the simulator to work on your PC
@zachwildd
Copy link

@zachwildd zachwildd commented Nov 30, 2020

Looks like you'll have to use self-hosted runners to get a GPU
@adeebshihadeh
Copy link
Contributor Author

@adeebshihadeh adeebshihadeh commented Nov 30, 2020

If we need to use a GPU, we can just run this on our existing jenkins machine, but it doesn't really need to run well. For now, we just want to check for crashes or regressions, like the grey panda deprecation breaking the sim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI good first issue simulation
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@geohot @zachwildd @adeebshihadeh @grekiki @ekdnam