Skip to content

Minor typo in subprocess.rst#25426

Merged
vstinner merged 1 commit intopython:masterfrom
akulakov:akulakov-patch-1
Apr 17, 2021
Merged

Minor typo in subprocess.rst#25426
vstinner merged 1 commit intopython:masterfrom
akulakov:akulakov-patch-1

Conversation

@akulakov
Copy link
Copy Markdown
Contributor

@akulakov akulakov commented Apr 15, 2021

Fix a typo per conversation w/ Vstinner on IRC.

@akulakov
Update subprocess.rst
49a0185 
Fix a typo per conversation w/ Vstinner on IRC.
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Apr 15, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@akulakov

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 15, 2021
@tirkarthi tirkarthi requested a review from vstinner April 17, 2021 06:33
@vstinner vstinner merged commit ea39f82 into python:master Apr 17, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 17, 2021

Thanks @akulakov for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 17, 2021

Thanks @akulakov for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 17, 2021

Sorry, @akulakov and @vstinner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ea39f82b97e0625334af560ef9876684d8e5abeb 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 17, 2021

Sorry @akulakov and @vstinner, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ea39f82b97e0625334af560ef9876684d8e5abeb 3.9

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Apr 17, 2021

Ah, Python 3.8 and 3.9 don't have the typo.

Thanks @akulakov, I merged your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@vstinner vstinner

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akulakov @the-knights-who-say-ni @miss-islington @vstinner @bedevere-bot @Fidget-Spinner