Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43795: Sort PC/python3dll.c #25312

Merged
merged 2 commits into from Apr 14, 2021
Merged

bpo-43795: Sort PC/python3dll.c #25312

merged 2 commits into from Apr 14, 2021

Conversation

@encukou
Copy link
Member

@encukou encukou commented Apr 9, 2021

Each section is sorted to reduce diffs (review effort) when the file becomes generated (PEP 652)
Sort is done with key=str.lower to preserve most of the original order (underscored items first).

https://bugs.python.org/issue43795

Each section is sorted to reduce diffs (review effort) when the file
becomes generated.
Sort is done with key=str.lower to preserve most of the original order
(underscored items first).
@encukou
Copy link
Member Author

@encukou encukou commented Apr 9, 2021

I'm putting this up as a separate PR to reduce conflicts. Discussions on the main PEP 652 PR might take a while.

Copy link
Member

@zware zware left a comment

Looks like the file mode was changed; was that intentional? Otherwise looks good to me :)

I have no idea why that changed...
@encukou
Copy link
Member Author

@encukou encukou commented Apr 14, 2021

I have no idea how I managed to change the mode. Thanks for the catch!

@encukou encukou merged commit 92eebf6 into python:master Apr 14, 2021
11 checks passed
11 checks passed
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Ubuntu SSL tests with OpenSSL ${{ matrix.openssl_ver }}
Details
Azure Pipelines PR #20210414.42 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 43795 found
Details
bedevere/news "skip news" label found
@encukou encukou deleted the encukou:pep652-sort branch Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants