Handle the Fact that themeSource isn't sticky#11826
Handle the Fact that themeSource isn't sticky#11826sergiou87 merged 3 commits intodesktop:developmentfrom
Conversation
There was a problem hiding this comment.
@say25 Thanks for looking at this! I was testing it out and am running into some odd behavior.
I spun up my Desktop-dev. I was in dark mode, which is my system theme setting.. but I have been setting it to light for cherry picking testing. (But due to the bug this pr is fixing, it doesn't remember that and goes back to Dark on each reload)
I then go to appearance. I expected to be set on system but I was on Dark. I figure this is just because I was last on dark before the update.
I then set my theme to light. It switches to light great! Then I close out Desktop-dev and spin it back up again. I expect it to remember my light mode selection. Sadness... it did not persist my selection. It is Dark again. However... I go to the preferences and light is selected just the light theme is not applied! I think this PR is heading the right direction, but needs one more step to apply locally stored theme.
|
Could that be some kind of race condition? Maybe we need to set the |
sergiou87
left a comment
There was a problem hiding this comment.
LGTM and seems to work fine now 😌
Thanks for taking care of this! ❤️
Description
Release notes
Notes: No Notes