Skip to content

/ backstage

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Blessed' icons for core plugins #4970

Open
tragiclifestories opened this issue Mar 16, 2021 · 2 comments
Open

'Blessed' icons for core plugins #4970

tragiclifestories opened this issue Mar 16, 2021 · 2 comments
Labels
enhancement good first issue help wanted

Comments

@tragiclifestories
Copy link
Contributor

@tragiclifestories tragiclifestories commented Mar 16, 2021

Feature Suggestion

Select icons to represent major parts of Backstage, for use in buttons and links into these components. EG:

  • catalog
  • scaffolder & templates
  • techdocs
  • search?

Possible Implementation

Probably just need to add them in here: https://github.com/backstage/backstage/blob/master/packages/core-api/src/icons/icons.tsx#L33-L44

Context

I bumped into this when changing the layout of some component to make use of icons and needing one to represent a link into the catalog. It occurred to me that it might be worth having a consistent choice for things like this. Discord discussion
@tragiclifestories tragiclifestories added the enhancement label Mar 16, 2021
@freben
Copy link
Member

@freben freben commented Mar 16, 2021

As I mention in the discussion - while it's a bit odd to have plugin concerns in the app builder, the mentioned plugins are so core that they warrant the exception. They are basically like default implementations of core concerns.
@freben freben added good first issue help wanted labels Mar 16, 2021
@chinmaym07
Copy link

@chinmaym07 chinmaym07 commented Mar 18, 2021

Hey Can I do this ? Also Can you please share the link to icons you want to add here ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@tragiclifestories @freben @chinmaym07