Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add viewmatcher selector to clients #13747

Open
KazuCocoa opened this issue Dec 19, 2019 · 4 comments
Open

add viewmatcher selector to clients #13747

KazuCocoa opened this issue Dec 19, 2019 · 4 comments

Comments

@KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Dec 19, 2019

Support using="-android viewmatcher", value="<JSON>"

appium/appium-espresso-driver#516

like #12372

Acceptance Criteria:

  • Ruby
  • Python
  • Java
  • C#
  • WebdriverIO ?
  • wd ?
@mykola-mokhnach
Copy link
Collaborator

@mykola-mokhnach mykola-mokhnach commented Dec 19, 2019

The corresponding changes in espresso driver have been published in version 1.19.0

@o-x-y-g-e-n
Copy link
Contributor

@o-x-y-g-e-n o-x-y-g-e-n commented Dec 19, 2019

Don't really understand the need to implement this method below
https://github.com/appium/python-client/blob/a2b9440af4dbb07bcb395a7631754844142e34cd/appium/webdriver/extensions/search_context/android.py#L59

onData() or onView() will throw an exception, if it finds multiple elements matching the same criteria.

Let me know what you guys think? @KazuCocoa @mykola-mokhnach

@KazuCocoa
Copy link
Member Author

@KazuCocoa KazuCocoa commented Dec 19, 2019

find elements returns elements as List and does not throw an exception unlike find element. find element should throw an exception if no element found, but find elements returns an empty list. (The error case also espresso driver must return an empty list for find elements call)

@mykola-mokhnach
Copy link
Collaborator

@mykola-mokhnach mykola-mokhnach commented May 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants