Extract the oauth package into a separate repo#2650
Merged
Conversation
vilmibm
approved these changes
Dec 18, 2020
Contributor
vilmibm
left a comment
There was a problem hiding this comment.
tested locally, looks good! do we actually intend to reimplement the debugging behavior marked as TODO?
muratkalenderoglu
approved these changes
Jan 2, 2021
muratkalenderoglu
approved these changes
Jan 2, 2021
Contributor
Author
That's a good question! I do not consider it strictly necessary, since it was mostly useful while developing the OAuth approach, but not as much now that it was unchanged for a while and has good test coverage. But, it might be easy to add via the injectable HTTP client, so I'll look into adding it before the merge. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the package that implements OAuth flow to https://github.com/cli/oauth