Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43174: Windows: Use /utf-8 compiler option. #24498

Merged
merged 4 commits into from Feb 12, 2021
Merged

bpo-43174: Windows: Use /utf-8 compiler option. #24498

merged 4 commits into from Feb 12, 2021
+2 −0

Conversation

@methane
Copy link
Member

@methane methane commented Feb 10, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue43174
methane added 2 commits Feb 10, 2021
@methane
bpo-43174: Windows: Use /utf8 compiler option.
d5b6007
@methane
add news
Loading status checks…
dceabe8
@methane methane added the OS-windows label Feb 10, 2021
@methane methane requested a review from python/windows-team Feb 10, 2021
@methane
fix
Loading status checks…
6a54854
@zooba
zooba approved these changes Feb 11, 2021
View changes
@methane
Update 2021-02-10-14-11-53.bpo-43174.F9zwXQ.rst
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f137813
@methane methane changed the title bpo-43174: Windows: Use /utf8 compiler option. bpo-43174: Windows: Use /utf-8 compiler option. Feb 12, 2021
@methane methane merged commit fedd86d into python:master Feb 12, 2021
11 checks passed
11 checks passed
Docs
Details
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20210211.14 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 43174 found
Details
bedevere/news News entry found in Misc/NEWS.d
@methane methane deleted the methane:win-utf8 branch Feb 12, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 12, 2021

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 12, 2021

GH-24513 is a backport of this pull request to the 3.9 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 12, 2021
@methane @miss-islington
bpo-43174: Windows: Use /utf-8 compiler option. (pythonGH-24498)
69efe8e 
(cherry picked from commit fedd86d)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this pull request Feb 12, 2021
@miss-islington @methane
bpo-43174: Windows: Use /utf-8 compiler option. (GH-24498)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
68d6bc7 
(cherry picked from commit fedd86d)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

Assignees
No one assigned
Labels
CLA signed OS-windows
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@methane @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni