Mark importlib and clinic headers as generated #7619
Merged
Conversation
zware
reviewed
Jun 13, 2018
Looks good, but there are several other generated files that we could also list here, like the unicodedata files, graminit, python-ast, etc.
|
I removed the |
zware
approved these changes
Jun 15, 2018
LGTM.
|
It doesn't hide diffs completely, but just makes them collapsed by default? Then LGTM! |
|
Thanks @methane for the PR |
|
GH-7707 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this issue
Jun 15, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguistGH-generated-code (cherry picked from commit c1897ed) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
|
GH-7708 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this issue
Jun 15, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguistGH-generated-code (cherry picked from commit c1897ed) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
|
It doesn't hide diffs completely, but just makes them collapsed by default?
You are right. Generated files are collapsed by default. Reviewer can
uncollapse them when they want.
--
INADA Naoki <songofacandy@gmail.com>
|
miss-islington
added a commit
that referenced
this issue
Jun 15, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguistGH-generated-code (cherry picked from commit c1897ed) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
miss-islington
added a commit
that referenced
this issue
Jun 15, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguistGH-generated-code (cherry picked from commit c1897ed) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
lisroach
added a commit
to lisroach/cpython
that referenced
this issue
Sep 10, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguist#generated-code
yahya-abou-imran
added a commit
to yahya-abou-imran/cpython
that referenced
this issue
Nov 2, 2018
Marked files are collapsed by default in Github pull request. https://github.com/github/linguist#generated-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We can specify generated files in
.gitattributes.Github doesn't render diff for generated files by default.
Sample pull request
The text was updated successfully, but these errors were encountered: